[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on B
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_STOP |
Date: |
Sun, 22 Apr 2018 09:37:27 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/20/2018 08:55 AM, Emilio G. Cota wrote:
> The TB after BS_STOP is not fixed (e.g. helper_mtc0_hwrena
> changes hflags, which ends up changing the TB flags via
> cpu_get_tb_cpu_state). This requires a full lookup (i.e.
> with flags) via lookup_and_goto_ptr instead of gen_goto_tb,
> since the latter only looks at the PC for in-page goto's. Fix it.
>
> Reported-by: Richard Henderson <address@hidden>
> Suggested-by: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/mips/translate.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v3 00/18] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 05/18] target/sparc: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 03/18] target/sparc: convert to DisasJumpType, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 04/18] target/sparc: convert to DisasContextBase, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 02/18] target/sh4: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_STOP, Emilio G. Cota, 2018/04/20
- Re: [Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_STOP,
Richard Henderson <=
- [Qemu-devel] [PATCH 01/18] translator: merge max_insns into DisasContextBase, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 10/18] target/mips: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 14/18] target/openrisc: convert to DisasContextBase, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 18/18] target/riscv: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 13/18] target/s390x: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 15/18] target/openrisc: convert to TranslatorOps, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 09/18] target/mips: use *ctx for DisasContext, Emilio G. Cota, 2018/04/20
- [Qemu-devel] [PATCH 16/18] target/riscv: convert to DisasJumpType, Emilio G. Cota, 2018/04/20