Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

[Tony Krowiak]

On 04/18/2018 06:55 AM, Halil Pasic wrote:
> On 04/15/2018 09:07 PM, Tony Krowiak wrote:
> > A new CPU model feature and two new CPU model facilities are
> > introduced to support AP devices for a KVM guest.
> [..]
> > diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c
> > index 3b9e274..5ee3a2d 100644
> > --- a/target/s390x/cpu_features.c
> > +++ b/target/s390x/cpu_features.c
> > @@ -40,8 +40,10 @@ static const S390FeatDef s390_features[] = {
> >       FEAT_INIT("srs", S390_FEAT_TYPE_STFL, 9, "Sense-running-status 
> > facility"),
> >       FEAT_INIT("csske", S390_FEAT_TYPE_STFL, 10, "Conditional-SSKE 
> > facility"),
> >       FEAT_INIT("ctop", S390_FEAT_TYPE_STFL, 11, 
> > "Configuration-topology facility"),
> > +    FEAT_INIT("apqci", S390_FEAT_TYPE_STFL, 12, "Query AP 
> > Configuration facility"),
>
> Why did you change this form qci to apqci. Too may people found the
> qci good?

I changed it by request and I thought it made sense to do so. Maybe we 
should just
take a vote.

> >       FEAT_INIT("ipter", S390_FEAT_TYPE_STFL, 13, "IPTE-range 
> > facility"),
> >       FEAT_INIT("nonqks", S390_FEAT_TYPE_STFL, 14, "Nonquiescing 
> > key-setting facility"),
> > +    FEAT_INIT("apft", S390_FEAT_TYPE_STFL, 15, "Adjunct Processor 
> > Facilities Test facility"),
> >       FEAT_INIT("etf2", S390_FEAT_TYPE_STFL, 16, 
> > "Extended-translation facility 2"),
> >       FEAT_INIT("msa-base", S390_FEAT_TYPE_STFL, 17, 
> > "Message-security-assist facility (excluding subfunctions)"),
> >       FEAT_INIT("ldisp", S390_FEAT_TYPE_STFL, 18, "Long-displacement 
> > facility"),
> > @@ -129,6 +131,7 @@ static const S390FeatDef s390_features[] = {
> >
> >       FEAT_INIT_MISC("dateh2", "DAT-enhancement facility 2"),
> >       FEAT_INIT_MISC("cmm", "Collaborative-memory-management facility"),
> > +    FEAT_INIT_MISC("ap", "AP facilities installed"),
>
> Why plural ('facilities')? Would not s/facilities/instructions be more 
> end-user
> friendly?
>
> Regards,
> Halil