[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 6/6] accel/tcg: convert 4/8 byte access and
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC PATCH 6/6] accel/tcg: convert 4/8 byte access and remove softmmu_template |
Date: |
Fri, 20 Apr 2018 11:36:26 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/20/2018 05:50 AM, Alex Bennée wrote:
> +tcg_target_ulong __attribute__((flatten)) helper_le_ldq_mmu(CPUArchState
> *env,
> + target_ulong
> addr,
> + TCGMemOpIdx oi,
> + uintptr_t
> retaddr)
> +{
> + return load_helper(env, addr, 8, false, false, oi, retaddr);
> +}
This doesn't work for 32-bit host.
You really do have to mind the block comment that you copied and use uint64_t,
both in load_helper and as the return value here.
> +#ifdef TARGET_WORDS_BIGENDIAN
> +#define NEED_BE_BSWAP 0
> +#define NEED_LE_BSWAP 1
> +#else
> +#define NEED_BE_BSWAP 1
> +#define NEED_LE_BSWAP 0
> +#endif
Why have two variables for this?
r~
- [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code, Alex Bennée, 2018/04/20
- [Qemu-devel] [RFC PATCH 1/6] accel/tcg: export some cputlb functions, Alex Bennée, 2018/04/20
- [Qemu-devel] [RFC PATCH 2/6] accel/tcg: new softmmu.c with DATA_SIZE=1, Alex Bennée, 2018/04/20
- [Qemu-devel] [RFC PATCH 3/6] accel/tcg: add DATA_SIZE = 2 to softmmu, Alex Bennée, 2018/04/20
- [Qemu-devel] [RFC PATCH 4/6] accel/tcg: create load_helper, Alex Bennée, 2018/04/20
- [Qemu-devel] [RFC PATCH 6/6] accel/tcg: convert 4/8 byte access and remove softmmu_template, Alex Bennée, 2018/04/20
- Re: [Qemu-devel] [RFC PATCH 6/6] accel/tcg: convert 4/8 byte access and remove softmmu_template,
Richard Henderson <=
- [Qemu-devel] [RFC PATCH 5/6] accel/tcg: create store_helper, Alex Bennée, 2018/04/20
- Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code, no-reply, 2018/04/20
- Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code, no-reply, 2018/04/20
- Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code, Paolo Bonzini, 2018/04/20
- Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code, Peter Maydell, 2018/04/20
- Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code, no-reply, 2018/04/20
- Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code, Emilio G. Cota, 2018/04/20