[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu-io read do not dump buffer when in quiet mode
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] qemu-io read do not dump buffer when in quiet mode |
Date: |
Fri, 20 Apr 2018 14:06:31 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/20/2018 11:14 AM, Junpeng.Li wrote:
>
> Hi, everyone. I found a question or maybe a bug during use qemu-io to read
> a range file and take the params -vq to dump buffer and do not show
> I/O statistics. I use the params -vq what i want is just dump buffer
> but do not show I/O statistics, but as the result show it is not.
>
> Like below command, it do not dump buffer to standard output.
>
> qemu-io -r -c "read -vq 0 1024" /tmp/test.qcow2
>
> I saw the source code, when has qflag value it just goto out and do
> not dump buffer when qflag and vflag has value at the same time.
>
> if (qflag) {
> goto out;
> }
>
> if (vflag) {
> dump_buffer(buf, offset, qiov.size);
> }
>
> quiet mode here, it mean do not show I/O statistics or mean complete quiet?
You're welcome to provide a patch to make it have saner behavior. As
long as running qemu-iotests doesn't break, we are pretty much free to
refactor qemu-io as it is more a tool for internal testing than for
external use.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature