[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 1/9] block: Add COR filter driver
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 1/9] block: Add COR filter driver |
Date: |
Fri, 20 Apr 2018 15:21:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-04-20 10:31, Stefan Hajnoczi wrote:
> On Mon, Apr 16, 2018 at 06:58:41PM +0200, Max Reitz wrote:
>> { 'enum': 'BlockdevDriver',
>> - 'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop',
>> + 'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop', 'cor',
>
> "copy-on-read" would be clearer than "cor" for the QMP API and the
> block/cor.c source file. Is there a need to make the name very short?
There definitely is no need. I decided I'd prefer to type less in the
test cases, so I went for the shorter name. (I thought blockdev-add was
sufficiently verbose as it is.)
But I don't mind un-abbreviating it either. (Probably better
considering that blockdev-add is already verbose, so there is no point
in making parts of it artificially dense.)
Thanks for reviewing!
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] block: Add COR filter driver, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 2/9] block: BLK_PERM_WRITE includes ..._UNCHANGED, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 1/9] block: Add COR filter driver, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 3/9] block: Add BDRV_REQ_WRITE_UNCHANGED flag, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 4/9] block: Set BDRV_REQ_WRITE_UNCHANGED for COR writes, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 5/9] block/quorum: Support BDRV_REQ_WRITE_UNCHANGED, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 6/9] block: Support BDRV_REQ_WRITE_UNCHANGED in filters, Max Reitz, 2018/04/16