Re: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/43] fix building of tests/tcg

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2cf210de25 tests: fp-test add fcvt support (!INCOMPLETE WIP)
c59ace380c tests/tcg: disable fp-test for 32 bit (HACK!)
3f6d6b37b3 tests/tcg/multiarch: add fp-test into multiarch set
a3942903d8 tests: add fp-test, a floating point test suite
93637ad78f softfloat: do not include glib headers
6cee90fce9 osdep: disable glib-compat.h include with QEMU_NO_GLIB
3f76b148e3 tests/Makefile.include: add (clean-)check-tcg targets
2b09de310b Makefile.target: add (clean-)guest-tests targets
64f32a347c tests/tcg/Makefile: update to be called from Makefile.target
b6dd1c4257 tests/tcg: enable building for ppc64
ed516c56c9 tests/tcg: enable building for s390x
af045c00c8 tests/tcg/mips: include common mips hello-mips
9c8573e3ad tests/tcg: enable building for MIPS
801dbba4ae tests/tcg: move MIPS specific tests into subdir
842030aa82 tests/tcg/aarch64: userspace system register test
a64644b63b tests/tcg/aarch64: add fcvt test cases for AArch64
1c9bd71293 tests/tcg/aarch64: add Makefile.target
c52e2f1c49 tests/tcg/arm: fix up test-arm-iwmmxt test
d14bdceb14 tests/tcg: move ARM specific tests into subdir
a929743e6c tests/tcg/i386/test-i386: fix printf format
1ab161b2e5 tests/tcg/i386/test-i386: use modern vector_size attributes
4a0590ba5e tests/tcg/x86_64: add Makefile.target
7732ca011f tests/tcg/i386: disable i386 version of test-i386-ssse
f95c12d39d tests/tcg/i386: fix test-i386-fprem
40782bcd69 tests/tcg/i386: fix test-i386
ea0cc36d3a tests/tcg/i386: Build fix for hello-i386
f86342742d tests/tcg: enable building for i386
c5ddd1785c docker: Add fedora-i386-cross image
58d31ffc85 tests/tcg: move i386 specific tests into subdir
0f322b2f8a tests/tcg/multiarch: enable additional linux-test tests
d2b649419a tests/tcg/multiarch: Build fix for linux-test
7c270a5818 tests/tcg: move architecture independent tests into subdir
fe04f2a58e docker: Makefile.include introduce DOCKER_SCRIPT
387090cde5 docker: allow "cc" command to run in user context
cc7e3225c2 docker: extend "cc" command to accept compiler
b2098ca1ca docker: Add "cc" subcommand
307a60adf2 Makefile: Rename TARGET_DIRS to TARGET_LIST
d6157c5262 configure: set cross_cc_FOO for host compiler
2afce5fc4d configure: allow user to specify --cross-cc-cflags-foo=
efd2616b8e configure: move i386_cc to cross_cc_i386
887941a91c configure: add support for --cross-cc-FOO
947d99fae7 configure: add test for docker availability
7e41971dca docker: add "probe" command for configure

=== OUTPUT BEGIN ===
Checking PATCH 1/43: docker: add "probe" command for configure...
Checking PATCH 2/43: configure: add test for docker availability...
Checking PATCH 3/43: configure: add support for --cross-cc-FOO...
Checking PATCH 4/43: configure: move i386_cc to cross_cc_i386...
Checking PATCH 5/43: configure: allow user to specify --cross-cc-cflags-foo=...
Checking PATCH 6/43: configure: set cross_cc_FOO for host compiler...
Checking PATCH 7/43: Makefile: Rename TARGET_DIRS to TARGET_LIST...
Checking PATCH 8/43: docker: Add "cc" subcommand...
Checking PATCH 9/43: docker: extend "cc" command to accept compiler...
Checking PATCH 10/43: docker: allow "cc" command to run in user context...
Checking PATCH 11/43: docker: Makefile.include introduce DOCKER_SCRIPT...
Checking PATCH 12/43: tests/tcg: move architecture independent tests into 
subdir...
Checking PATCH 13/43: tests/tcg/multiarch: Build fix for linux-test...
ERROR: if this code is redundant consider removing it
#153: FILE: tests/tcg/multiarch/linux-test.c:323:
+#if 0

total: 1 errors, 0 warnings, 185 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 14/43: tests/tcg/multiarch: enable additional linux-test tests...
Checking PATCH 15/43: tests/tcg: move i386 specific tests into subdir...
Checking PATCH 16/43: docker: Add fedora-i386-cross image...
Checking PATCH 17/43: tests/tcg: enable building for i386...
Checking PATCH 18/43: tests/tcg/i386: Build fix for hello-i386...
ERROR: externs should be avoided in .c files
#21: FILE: tests/tcg/i386/hello-i386.c:23:
+void _start(void);

total: 1 errors, 0 warnings, 7 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/43: tests/tcg/i386: fix test-i386...
Checking PATCH 20/43: tests/tcg/i386: fix test-i386-fprem...
Checking PATCH 21/43: tests/tcg/i386: disable i386 version of test-i386-ssse...
Checking PATCH 22/43: tests/tcg/x86_64: add Makefile.target...
Checking PATCH 23/43: tests/tcg/i386/test-i386: use modern vector_size 
attributes...
Checking PATCH 24/43: tests/tcg/i386/test-i386: fix printf format...
Checking PATCH 25/43: tests/tcg: move ARM specific tests into subdir...
Checking PATCH 26/43: tests/tcg/arm: fix up test-arm-iwmmxt test...
Checking PATCH 27/43: tests/tcg/aarch64: add Makefile.target...
Checking PATCH 28/43: tests/tcg/aarch64: add fcvt test cases for AArch64...
ERROR: space prohibited before open square bracket '['
#281: FILE: tests/tcg/aarch64/fcvt.c:244:
+        : /* no output */ : [flags] "n" (1 << 26) : "x1" );

ERROR: space prohibited before that close parenthesis ')'
#281: FILE: tests/tcg/aarch64/fcvt.c:244:
+        : /* no output */ : [flags] "n" (1 << 26) : "x1" );

total: 2 errors, 0 warnings, 1587 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 29/43: tests/tcg/aarch64: userspace system register test...
Checking PATCH 30/43: tests/tcg: move MIPS specific tests into subdir...
Checking PATCH 31/43: tests/tcg: enable building for MIPS...
Checking PATCH 32/43: tests/tcg/mips: include common mips hello-mips...
Checking PATCH 33/43: tests/tcg: enable building for s390x...
Checking PATCH 34/43: tests/tcg: enable building for ppc64...
Checking PATCH 35/43: tests/tcg/Makefile: update to be called from 
Makefile.target...
Checking PATCH 36/43: Makefile.target: add (clean-)guest-tests targets...
Checking PATCH 37/43: tests/Makefile.include: add (clean-)check-tcg targets...
Checking PATCH 38/43: osdep: disable glib-compat.h include with QEMU_NO_GLIB...
Checking PATCH 39/43: softfloat: do not include glib headers...
Checking PATCH 40/43: tests: add fp-test, a floating point test suite...
ERROR: Macros with complex values should be enclosed in parenthesis
#382: FILE: tests/fp/fp-test.c:221:
+#define PR_EXCEPTIONS(x)                                \
+        ((x) & STANDARD_EXCEPTIONS ? "" : "none"),      \
+        (((x) & float_flag_inexact)   ? "x" : ""),      \
+        (((x) & float_flag_underflow) ? "u" : ""),      \
+        (((x) & float_flag_overflow)  ? "o" : ""),      \
+        (((x) & float_flag_divbyzero) ? "z" : ""),      \
+        (((x) & float_flag_invalid)   ? "i" : "")

ERROR: consider using qemu_strtoul in preference to strtoul
#844: FILE: tests/fp/fp-test.c:683:
+            significand = strtoul(&p[3], &pos, 16);

ERROR: consider using qemu_strtol in preference to strtol
#849: FILE: tests/fp/fp-test.c:688:
+            exponent = strtol(pos, &pos, 10) + 127;

ERROR: consider using qemu_strtoul in preference to strtoul
#874: FILE: tests/fp/fp-test.c:713:
+            significand = strtoul(&p[3], &pos, 16);

ERROR: consider using qemu_strtol in preference to strtol
#879: FILE: tests/fp/fp-test.c:718:
+            exponent = strtol(pos, &pos, 10) + 1023;

ERROR: consider using qemu_strtof in preference to strtof
#898: FILE: tests/fp/fp-test.c:737:
+            float f = strtof(p, &pos);

ERROR: externs should be avoided in .c files
#1187: FILE: tests/fp/fp-test.c:1026:
+    int hsearch_r(ENTRY item, ACTION action, ENTRY **retval,

total: 7 errors, 0 warnings, 1233 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 41/43: tests/tcg/multiarch: add fp-test into multiarch set...
Checking PATCH 42/43: tests/tcg: disable fp-test for 32 bit (HACK!)...
Checking PATCH 43/43: tests: fp-test add fcvt support (!INCOMPLETE WIP)...
ERROR: consider using qemu_strtoull in preference to strtoull
#591: FILE: tests/fp/fp-test.c:1150:
+        result = strtoull(p, &end, 16);

total: 1 errors, 0 warnings, 644 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden