[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] docker: Rename the amd64 image as amd64-cross
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH] docker: Rename the amd64 image as amd64-cross |
|
Date: |
Fri, 20 Apr 2018 10:57:59 +0800 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, 04/19 23:40, Philippe Mathieu-Daudé wrote:
> Like the other images, this one is also used to cross-compile.
> Name it accordingly, matching directory pattern.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/docker/Makefile.include | 2 +-
> .../{debian-amd64.docker => debian-amd64-cross.docker} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename tests/docker/dockerfiles/{debian-amd64.docker =>
> debian-amd64-cross.docker} (100%)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index de87341528..a113a15f77 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -49,7 +49,7 @@ docker-image-debian-powerpc-cross:
> EXTRA_FILES:=$(SRC_PATH)/tests/docker/dockerf
> # Enforce dependancies for composite images
> docker-image-debian: docker-image-debian9
> docker-image-debian8-mxe: docker-image-debian8
> -docker-image-debian-amd64: docker-image-debian9
> +docker-image-debian-amd64-cross: docker-image-debian9
> docker-image-debian-armel-cross: docker-image-debian9
> docker-image-debian-armhf-cross: docker-image-debian9
> docker-image-debian-arm64-cross: docker-image-debian9
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker
> b/tests/docker/dockerfiles/debian-amd64-cross.docker
> similarity index 100%
> rename from tests/docker/dockerfiles/debian-amd64.docker
> rename to tests/docker/dockerfiles/debian-amd64-cross.docker
But the dockerfile is written differently: it doesn't use the --cross-prefix
configure option, plus, amd64 is usually the "native" arch making it non-cross
build.
What do you need this patch for beside the consistency?
Fam