Re: [Qemu-devel] [PATCH v5 0/5] Simplify qobject refcount

[Marc-André Lureau]

Hi

On Thu, Apr 19, 2018 at 12:09 PM, Marc-André Lureau
<address@hidden> wrote:
>> On the one hand, we provide safe conversion macros QOBJECT() and
>> qobject_to().  By the way, shouting one but not the other is a bit ugly.
>
> QOBJECT is static upcast, the compiler will shout.
> qobject_to() is dynamic downcast, the runtime shout.

Actually it doesn't shout, it merely tries and return NULL if it can't
do it. So I understand what you mean now. So it's a balance, but so
far, it seems those 2 fit our needs.

> I don't like to spent too much time on this, yet as you said, this is
> a lovely improvement, so is there any real blocker left?

I'll try to address your comments from v5 patches and send a v6.


-- 
Marc-André Lureau