[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.13] tcg: Allow wider vectors for cmp and m
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-2.13] tcg: Allow wider vectors for cmp and mul |
Date: |
Thu, 19 Apr 2018 11:17:17 +0100 |
On 17 April 2018 at 23:12, Richard Henderson
<address@hidden> wrote:
> In db432672, we allow wide inputs for operations such as add.
> However, in 212be173 and 3774030a we didn't do the same for
> compare and multiply.
>
> Signed-off-by: Richard Henderson <address@hidden>
Can we hit these asserts in the uses of tcg_gen_mul_vec
and tcg_gen_cmp_vec currently in the aarch64 frontend, or
is this only a problem for the not-yet-landed SVE code?
I notice that do_shifti() also has a
tcg_debug_assert(at->base_type == type);
Is that assert correct, or should it also be changed to >= ?
thanks
-- PMM