qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 for-2.13 1/4] pc-bios/s390-ccw/net: Split up


From: Farhan Ali
Subject: Re: [Qemu-devel] [PATCH v1 for-2.13 1/4] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts
Date: Wed, 18 Apr 2018 14:11:27 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0



On 04/18/2018 08:31 AM, Thomas Huth wrote:
When we want to support pxelinux-style network booting later, we've got
to do several TFTP transfers - and we do not want to apply for a new IP
address via DHCP each time. So split up net_load into three parts:

1. net_init(), which initializes virtio-net, gets an IP address via DHCP
    and prints out the related information.

2. The tftp_load call is now moved directly into the main() function

3. A new net_uninit() function which should tear down the network stack
    before we are done in the firmware.

This will make it easier to extend the code in the next patches.

Signed-off-by: Thomas Huth<address@hidden>


Just a minor nit, if we could rename *_uninit functions to destroy/release? I think it's just easier to read




reply via email to

[Prev in Thread] Current Thread [Next in Thread]