Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux

[Paolo Bonzini]

On 18/04/2018 16:54, Olaf Hering wrote:
> Since usage of g_realloc_n was introduced, glib-2.22 can not be used
> anymore on Linux. Leave non-Linux unchanged because one developer system
> still uses it.
> Fixes commit 418026ca43 ("util: Introduce vfio helpers")
> 
> Signed-off-by: Olaf Hering <address@hidden>
> ---
>  configure | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 6e9b994f21..ca19a66726 100755
> --- a/configure
> +++ b/configure
> @@ -3369,7 +3369,11 @@ fi
>  if test "$mingw32" = yes; then
>      glib_req_ver=2.30
>  else
> -    glib_req_ver=2.22
> +    if test "$targetos" = Linux; then
> +       glib_req_ver=2.24
> +    else
> +       glib_req_ver=2.22
> +    fi
>  fi
>  glib_modules=gthread-2.0
>  if test "$modules" = yes; then
> 

I think for 2.12 it's okay to just document this.  For 2.13 we should
raise the bar uniformly (and anyway remove g_realloc_n in favor of g_renew).

Paolo