Re: [Qemu-devel] [PATCH v1 12/24] tests/tcg/i386: Build fix for hello-i386

[Alex Bennée]

Philippe Mathieu-Daudé <address@hidden> writes:

> Hi Fam, Alex,
>
> On 04/10/2018 04:39 PM, Alex Bennée wrote:
>> From: Fam Zheng <address@hidden>
>> 
>> We have -Werror=missing-prototype, add a dummy prototype to avoid that
>> warning.
>> 
>> Signed-off-by: Fam Zheng <address@hidden>
>> ---
>>  tests/tcg/i386/hello-i386.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/tests/tcg/i386/hello-i386.c b/tests/tcg/i386/hello-i386.c
>> index fa00380de2..cfeb24b2f5 100644
>> --- a/tests/tcg/i386/hello-i386.c
>> +++ b/tests/tcg/i386/hello-i386.c
>> @@ -20,6 +20,7 @@ static inline int write(int fd, const char * buf, int len)
>>    return status;
>>  }
>>  
>> +void _start(void);
>
> What about adding that in a common base file include by all tcg tests?
> Such tests/tcg/include/tcg-common.h or better name...

For this I don't think it makes much sense. Not all linux-user tests are
quite so bare bones...

>
>>  void _start(void)
>>  {
>>      write(1, "Hello World\n", 12);
>> 


-- 
Alex Bennée