[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.13 1/4] arm: reuse arm_boot_address_space(
|
From: |
Igor Mammedov |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.13 1/4] arm: reuse arm_boot_address_space() in armv7m_load_kernel() |
|
Date: |
Fri, 13 Apr 2018 15:41:00 +0200 |
On Thu, 12 Apr 2018 19:22:13 +0100
Peter Maydell <address@hidden> wrote:
> On 12 April 2018 at 17:40, Igor Mammedov <address@hidden> wrote:
> > reduce code duplication by resusing arm_boot_address_space()
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > include/hw/arm/arm.h | 2 ++
> > hw/arm/armv7m.c | 10 +---------
> > hw/arm/boot.c | 16 ++++++++--------
> > 3 files changed, 11 insertions(+), 17 deletions(-)
>
> This minor duplication was deliberate, because hw/arm/armv7m.c
> is for M profile cores only, and hw/arm/boot.c is for
> A/R profile cores only. I don't think that saving a
> single if/else in armv7m.c really justifies blurring
> that dividing line.
I'll drop patch on respin
> thanks
> -- PMM
Re: [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier, Peter Maydell, 2018/04/16
[Qemu-devel] [PATCH for-2.13 4/4] arm/boot: split load_dtb() from arm_load_kernel(), Igor Mammedov, 2018/04/12