[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 13/24] tests/tcg/i386: move test-i386-sse.c t
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v1 13/24] tests/tcg/i386: move test-i386-sse.c to tests/tcg/x86_64/test-sse.c |
Date: |
Wed, 11 Apr 2018 17:19:11 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Thomas Huth <address@hidden> writes:
> On 10.04.2018 21:39, Alex Bennée wrote:
>> The test mixes up 32bit and 64 bit code. It should probably be split
>> into two distinct test cases. However for now just move it out of the
>> way of the i386 build.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> tests/tcg/{i386/test-i386-ssse3.c => x86_64/test-sse.c} | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>> rename tests/tcg/{i386/test-i386-ssse3.c => x86_64/test-sse.c} (93%)
>
> Do we really want to have a separate x86_64 folder here? We also have
> 64-bit code in hw/i386/ and target/i386/ so I don't think that we should
> handle this differently for tests/tcg/i386 ? Wouldn't it be sufficient
> to simply move this code to a separate file? ... just my 0.02 €
It's certainly simpler for the build rules to have a simple mapping from
$(TARGET_NAME) to tests/tcg/FOO....
--
Alex Bennée
- [Qemu-devel] [PATCH v1 06/24] docker: extend "cc" command to accept compiler, (continued)
- [Qemu-devel] [PATCH v1 06/24] docker: extend "cc" command to accept compiler, Alex Bennée, 2018/04/10
- [Qemu-devel] [PATCH v1 07/24] docker: allow "cc" command to run in user context, Alex Bennée, 2018/04/10
- [Qemu-devel] [PATCH v1 09/24] tests/tcg: move architecture independent tests into subdir, Alex Bennée, 2018/04/10
- [Qemu-devel] [PATCH v1 13/24] tests/tcg/i386: move test-i386-sse.c to tests/tcg/x86_64/test-sse.c, Alex Bennée, 2018/04/10
- [Qemu-devel] [PATCH v1 10/24] tests/tcg/multiarch: Build fix for linux-test, Alex Bennée, 2018/04/10
- [Qemu-devel] [PATCH v1 14/24] tests/tcg/i386: fix test-i386, Alex Bennée, 2018/04/10
- [Qemu-devel] [PATCH v1 15/24] tests/tcg/i368: fix hello-i386, Alex Bennée, 2018/04/10
- [Qemu-devel] [PATCH v1 18/24] tests/tcg/arm: fix hello-arm, Alex Bennée, 2018/04/10