[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] icount: fix cpu_restore_state_from_tb for non-t

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] icount: fix cpu_restore_state_from_tb for non-tb-exit cases
Date: Tue, 10 Apr 2018 19:39:31 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 04/10/2018 05:35 PM, Paolo Bonzini wrote:
> This is incorrect, "cpu->can_do_io" is 1 when not in tcg_qemu_tb_exec.
> In fact, in cpu_exec we have "cpu->can_do_io = 1;" immediately after
> siglongjmp, so I propose adding the same "cpu->can_do_io = 1;"
> assignment to cpu_exec_step_atomic.

Ooo, good catch.  I agree.

> In any case, please change the two siglongjmp of
> cpu_loop_exit_{noexc,restore} to cpu_loop_exit, instead of duplicating
> that cpu->can_do_io assignment.

I've made that change too.  I'll post a v2 shortly.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]