[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled |
Date: |
Tue, 10 Apr 2018 13:13:31 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Apr 09, 2018 at 07:37:11PM +0200, Paolo Bonzini wrote:
> On 09/04/2018 11:24, Peter Maydell wrote:
> > On 9 April 2018 at 09:31, Daniel P. Berrangé <address@hidden> wrote:
> >> Feels to me that since we've deprecated 2.0, we could just *never* auto
> >> detect - just do test -z "$gtkabi" && gtkabi=3.0
> >>
> >> Anyone who wants gtk2 should have to use an explicit --with-gtkabi=2.0
> >
> > I think if we still work with gtk2 then we should go ahead and
> > warn-but-use it.
>
> Both are valid choices of course. Since we have Peter (Xu)'s patch, I
> think we should go for that and revisit in 2.13 whether to remove GTK+
> 2.0 support altogether, require an explicit configure argument, or leave
> things as they are.
Thanks all. Please anyone let me know if a repost is needed. Otherwise
I'll keep it as is and I can try to post a similar one for SDL.
--
Peter Xu