[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.12] target/arm: Don't corrupt insn_start a

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH for-2.12] target/arm: Don't corrupt insn_start arguments on 32-bit hosts
Date: Tue, 10 Apr 2018 08:09:02 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 04/09/2018 08:38 PM, Peter Maydell wrote:
>      tcg_set_insn_param(s->insn_start, 2, syn);
> +#else
> +    /* tcg_gen_insn_start has split every target_ulong argument to
> +     * op_insn_start into two 32-bit arguments, so we want the low
> +     * half of the 3rd argument, which is at index 4.
> +     */
> +    tcg_set_insn_param(s->insn_start, 4, syn);
> +#endif

Ouch, good catch.

I think we should fix this in tcg_set_insn_param instead,
as several other targets are also affected by this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]