[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled |
|
Date: |
Mon, 9 Apr 2018 19:37:11 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 09/04/2018 11:24, Peter Maydell wrote:
> On 9 April 2018 at 09:31, Daniel P. Berrangé <address@hidden> wrote:
>> Feels to me that since we've deprecated 2.0, we could just *never* auto
>> detect - just do test -z "$gtkabi" && gtkabi=3.0
>>
>> Anyone who wants gtk2 should have to use an explicit --with-gtkabi=2.0
>
> I think if we still work with gtk2 then we should go ahead and
> warn-but-use it.
Both are valid choices of course. Since we have Peter (Xu)'s patch, I
think we should go for that and revisit in 2.13 whether to remove GTK+
2.0 support altogether, require an explicit configure argument, or leave
things as they are.
Paolo