[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 1/2] s390x/mmu: don't o
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pending exception in mmu translate |
Date: |
Mon, 9 Apr 2018 13:55:29 +0200 |
On Mon, 9 Apr 2018 13:50:03 +0200
Christian Borntraeger <address@hidden> wrote:
> On 04/09/2018 01:30 PM, David Hildenbrand wrote:
> > If we already triggered another exception, don't overwrite it with a
> > protection exception.
> >
> > Signed-off-by: David Hildenbrand <address@hidden>
>
>
> Can you add your description from the cover letter regarding
> "only applies to old KVM instances without the virtual memory access
> IOCTL in KVM."
Will add that.
>
> with that
> Acked-by: Christian Borntraeger <address@hidden>
> > ---
> > target/s390x/mmu_helper.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> > index 1deeb6e6e4..a25deef5dd 100644
> > --- a/target/s390x/mmu_helper.c
> > +++ b/target/s390x/mmu_helper.c
> > @@ -325,7 +325,7 @@ static int mmu_translate_asce(CPUS390XState *env,
> > target_ulong vaddr,
> >
> > r = mmu_translate_region(env, vaddr, asc, asce, level, raddr, flags,
> > rw,
> > exc);
> > - if (rw == MMU_DATA_STORE && !(*flags & PAGE_WRITE)) {
> > + if (!r && rw == MMU_DATA_STORE && !(*flags & PAGE_WRITE)) {
> > trigger_prot_fault(env, vaddr, asc, rw, exc);
> > return -1;
> > }
> >
>
- Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, (continued)
- Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Christian Borntraeger, 2018/04/09
- Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, David Hildenbrand, 2018/04/09
- Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Christian Borntraeger, 2018/04/09
- Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, David Hildenbrand, 2018/04/09
- Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Christian Borntraeger, 2018/04/09
- Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Cornelia Huck, 2018/04/09
Re: [Qemu-devel] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Thomas Huth, 2018/04/09
[Qemu-devel] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pending exception in mmu translate, David Hildenbrand, 2018/04/09
Re: [Qemu-devel] [PATCH v1 for-2.12 0/2] s390x/kvm: last minute fixes, Cornelia Huck, 2018/04/09