[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Split 214 off of 122

From: Alberto Garcia
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Split 214 off of 122
Date: Mon, 09 Apr 2018 11:28:39 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 06 Apr 2018 06:41:08 PM CEST, Max Reitz <address@hidden> wrote:
> Commit abd3622cc03cf41ed542126a540385f30a4c0175 added a case to 122
> regarding how the qcow2 driver handles an incorrect compressed data
> length value.  This does not really fit into 122, as that file is
> supposed to contain qemu-img convert test cases, which this case is not.
> So this patch splits it off into its own file; maybe we will even get
> more qcow2-only compression tests in the future.
> Also, that test case does not work with refcount_bits=1, so mark that
> option as unsupported.
> Signed-off-by: Max Reitz <address@hidden>

Looks good to me

> I was a bit lost what to do about the copyright text, since this test
> case was written by Berto.  I figured I'd drop the "owner" variable
> (it isn't used anyway), but I put "Red Hat" into the copyright line --
> currently every test has copyright information, so I decided it'd be
> difficult to leave that out, and I figured I simply cannot claim
> copyright for Igalia.  So, here we go.

The new file contains only my test, right? You can use

Copyright (C) 2018 Igalia, S.L.
Author: Alberto Garcia <address@hidden>

and add

Signed-off-by: Alberto Garcia <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]