[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.13 v5 04/11] hmp: disable monitor in preconfig
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH for-2.13 v5 04/11] hmp: disable monitor in preconfig state |
Date: |
Thu, 5 Apr 2018 11:05:06 +0200 |
Ban it for now, if someone would need it to work early,
one would have to implement checks if HMP command is valid
at preconfig state.
Signed-off-by: Igor Mammedov <address@hidden>
---
v5:
* add 'use QMP instead" to error message, suggesting user
the right interface to use
v4:
* v3 was only printing error but not preventing command execution,
Fix it by returning after printing error message.
("Dr. David Alan Gilbert" <address@hidden>)
---
monitor.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/monitor.c b/monitor.c
index 51f4cf4..fd1e7c8 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3374,6 +3374,12 @@ static void handle_hmp_command(Monitor *mon, const char
*cmdline)
trace_handle_hmp_command(mon, cmdline);
+ if (runstate_check(RUN_STATE_PRECONFIG)) {
+ monitor_printf(mon, "HMP not available in preconfig state, "
+ "use QMP instead\n");
+ return;
+ }
+
cmd = monitor_parse_command(mon, cmdline, &cmdline, mon->cmd_table);
if (!cmd) {
return;
--
2.7.4
- [Qemu-devel] [PATCH for-2.13 v5 00/11] enable numa configuration before machine_init() from QMP, Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 01/11] numa: postpone options post-processing till machine_run_board_init(), Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 04/11] hmp: disable monitor in preconfig state,
Igor Mammedov <=
- [Qemu-devel] [PATCH for-2.13 v5 07/11] tests: add allowed-in-preconfig-test for qapi-schema, Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 05/11] qapi: introduce new cmd option "allowed-in-preconfig", Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 03/11] cli: add --preconfig option, Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 09/11] qmp: permit query-hotpluggable-cpus in preconfig state, Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 06/11] tests: let qapi-schema tests detect allowed-in-preconfig, Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 11/11] tests: functional tests for QMP command set-numa-node, Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 10/11] qmp: add set-numa-node command, Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 02/11] numa: split out NumaOptions parsing into set_numa_options(), Igor Mammedov, 2018/04/05
- [Qemu-devel] [PATCH for-2.13 v5 08/11] tests: extend qmp test with preconfig checks, Igor Mammedov, 2018/04/05