qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test


From: Su Hang
Subject: Re: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case
Date: Thu, 5 Apr 2018 00:00:31 +0800 (GMT+08:00)

A bit embarrassing, this mistake was introduced by me. I submitted a 
corresponding patch to fix it, but no one has reviewed it.
See link below:
http://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg06506.html

"Eric Blake" <address@hidden>wrote:
> On 04/03/2018 10:37 AM, address@hidden wrote:
> > Hi,
> > 
> > This series seems to have some coding style problems. See output below for
> > more information:
> > 
> 
> > === OUTPUT BEGIN ===
> > Checking PATCH 1/2: Implement .hex file loader...
> > ERROR: braces {} are necessary for all arms of this statement
> > #220: FILE: hw/core/loader.c:1463:
> > +    } while (++hex_blob != end);
> > [...]
> 
> False positive; this is a known bug in checkpatch.pl, and there is even
> a patch proposed to resolve it, but no one has incorporated the patch yet:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05232.html
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
> 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]