[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend suppor
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend support |
Date: |
Wed, 4 Apr 2018 06:11:27 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend support
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
094b62cd9c..e5efa1f5f2 master -> master
* [new tag] patchew/address@hidden -> patchew/address@hidden
t [tag update] patchew/address@hidden -> patchew/address@hidden
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a5ed4f9354 virtio: queue pop support for packed ring
eda38cccfc virtio: get avail bytes check for packed ring
d6b7b8f192 virtio: flush/push support for packed ring
2ae1f234dc virtio: notification tweak for packed ring
5c44b67629 virtio: add detach element for packed ring(1.1)
7bc7372e93 virtio: add empty check for packed ring
cf399da035 virtio: memory cache for packed ring
606ec5dc23 virtio: feature bit, data structure for packed ring
=== OUTPUT BEGIN ===
Checking PATCH 1/8: virtio: feature bit, data structure for packed ring...
ERROR: open brace '{' following struct go on the same line
#21: FILE: hw/virtio/virtio.c:43:
+typedef struct VRingDescPacked
+{
ERROR: open brace '{' following struct go on the same line
#64: FILE: hw/virtio/virtio.c:104:
+typedef struct VRingPacked
+{
total: 2 errors, 0 warnings, 104 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/8: virtio: memory cache for packed ring...
Checking PATCH 3/8: virtio: add empty check for packed ring...
ERROR: "foo* bar" should be "foo *bar"
#40: FILE: hw/virtio/virtio.c:463:
+static inline bool is_desc_avail(struct VRingDescPacked* desc)
ERROR: return is not a function, parentheses are not required
#42: FILE: hw/virtio/virtio.c:465:
+ return (!!(desc->flags & AVAIL_DESC_PACKED(1)) !=
WARNING: line over 80 characters
#77: FILE: hw/virtio/virtio.c:513:
+ vring_desc_read_packed(vq->vdev, &desc, &cache->desc_packed,
vq->last_avail_idx);
total: 2 errors, 1 warnings, 95 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/8: virtio: add detach element for packed ring(1.1)...
Checking PATCH 5/8: virtio: notification tweak for packed ring...
Checking PATCH 6/8: virtio: flush/push support for packed ring...
Checking PATCH 7/8: virtio: get avail bytes check for packed ring...
ERROR: braces {} are necessary for all arms of this statement
#125: FILE: hw/virtio/virtio.c:1056:
+ } while (desc.flags & VRING_DESC_F_NEXT);
[...]
total: 1 errors, 0 warnings, 154 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/8: virtio: queue pop support for packed ring...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH 3/8] virtio: add empty check for packed ring, (continued)
- [Qemu-devel] [PATCH 5/8] virtio: notification tweak for packed ring, wexu, 2018/04/04
- [Qemu-devel] [PATCH 6/8] virtio: flush/push support for packed ring, wexu, 2018/04/04
- [Qemu-devel] [PATCH 7/8] virtio: get avail bytes check for packed ring, wexu, 2018/04/04
- [Qemu-devel] [PATCH 8/8] virtio: queue pop support for packed ring, wexu, 2018/04/04
- Re: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend support, no-reply, 2018/04/04
- Re: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend support, no-reply, 2018/04/04
- Re: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend support,
no-reply <=
- Re: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend support, Jason Wang, 2018/04/09