[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code |
Date: |
Wed, 4 Apr 2018 10:24:33 +0100 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Wed, Apr 04, 2018 at 05:07:56PM +0800, Fam Zheng wrote:
> On Wed, 04/04 09:23, Daniel P. Berrangé wrote:
> > On Wed, Apr 04, 2018 at 10:51:59AM +0800, Fam Zheng wrote:
> > > ./configure and make now take care of submodules, we only need to clone
> > > the top tree.
> >
> > If you don't include the submodules in the tar.gz archive, then the
> > test system needs to be able to clone them from qemu.org, which
> > requires networking.
> >
> > The VM tests have networking by default, but the docker tests do
> > not have networking - you need to opt-in by setting NETWORK=1
> > make variable. So AFAICT, this will break docker tests.
>
> Yes, I'll revise the patch.
BTW, I can't help feeling that scripts/archive-source.sh should not even
exist. We already have scripts/make-release that has significant overlap
of functionality and is used by 'make dist'. Ideally imho we should be
able to either invoke 'make dist' for testing, or call make-release.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-devel] [PATCH 2/3] tests: Add an option for snapshot (default: off), Fam Zheng, 2018/04/03
[Qemu-devel] [PATCH 3/3] tests: Add centos VM testing, Fam Zheng, 2018/04/03
Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests, no-reply, 2018/04/03
Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests, no-reply, 2018/04/04
Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests, Peter Xu, 2018/04/04
Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests, Daniel P . Berrangé, 2018/04/04
Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests, Paolo Bonzini, 2018/04/06