[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: fix error propagation in clock_gett
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: fix error propagation in clock_gettime |
Date: |
Sun, 1 Apr 2018 23:15:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Le 01/04/2018 à 23:05, Laurent Vivier a écrit :
> Le 01/04/2018 à 22:37, Max Filippov a écrit :
>> host_to_target_timespec may return error if target address could not be
>> locked, but it is ignored.
>> Propagate return value of host_to_target_timespec to the caller of
>> clock_gettime.
>>
>> Signed-off-by: Max Filippov <address@hidden>
>> ---
>> linux-user/syscall.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index d51e2a00ee31..52e2f9c16479 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -11884,7 +11884,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
>> arg1,
>> struct timespec ts;
>> ret = get_errno(clock_gettime(arg1, &ts));
>> if (!is_error(ret)) {
>> - host_to_target_timespec(arg2, &ts);
>> + ret = host_to_target_timespec(arg2, &ts);
>> }
>> break;
>> }
>>
>
> Could you also update in the same way clock_getres?
Ignore this, clock_getres() accepts a NULL pointer.
so:
Reviewed-by: Laurent Vivier <address@hidden>
Thanks,
Laurent