Re: [Qemu-devel] [PATCH 1/3] exec: fix memory leak in find_max_supported_pagesize()

[Cornelia Huck]

On Thu, 29 Mar 2018 11:09:46 +0200
Greg Kurz <address@hidden> wrote:

> The string returned by object_property_get_str() is dynamically allocated.
> 
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>  exec.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/exec.c b/exec.c
> index c09bd93df31e..02b1efebb7c3 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1495,6 +1495,7 @@ static int find_max_supported_pagesize(Object *obj, 
> void *opaque)
>          mem_path = object_property_get_str(obj, "mem-path", NULL);
>          if (mem_path) {
>              long hpsize = qemu_mempath_getpagesize(mem_path);
> +            g_free(mem_path);
>              if (hpsize < *hpsize_min) {
>                  *hpsize_min = hpsize;
>              }
> 

Personally, I'd probably do the g_free() at the end of the if
(mem_path) branch, but this works as well.

Reviewed-by: Cornelia Huck <address@hidden>