[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] vmdk: return ERROR when cluster sector is la
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] vmdk: return ERROR when cluster sector is larger than vmdk limitation |
|
Date: |
Mon, 26 Mar 2018 18:29:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-03-22 14:33, address@hidden wrote:
> From: yuchenlin <address@hidden>
>
> VMDK has a hard limitation of extent size, which is due to the size of grain
> table entry is 32 bits. It means it can only point to a grain located at
> offset = 2^32. To avoid writing the user data beyond limitation and record a
> useless offset
> in grain table. We should return ERROR here.
>
> Signed-off-by: yuchenlin <address@hidden>
> ---
> v2->v3:
> - use (1ULL << 32) to clearly show the limitation of offset is 2^32.
>
> thanks
>
> block/vmdk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Thanks, applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
signature.asc
Description: OpenPGP digital signature