[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions() |
Date: |
Mon, 26 Mar 2018 10:38:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 23/03/2018 21:49, Eric Blake wrote:
> On 03/23/2018 03:42 PM, Eduardo Habkost wrote:
>> On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote:
>>> it will allow to reuse parse_NumaOptions() for parsing
>>> configuration commands received via QMP interface
>>>
>>> Signed-off-by: Igor Mammedov <address@hidden>
>>> ---
>
>>> end:
>>> + if (err) {
>>> + error_propagate(errp, err);
>>> + }
>>
>> "if (err)" is not necessary here. See
>> scripts/coccinelle/error_propagate_null.cocci.
>>
>
>>> + parse_NumaOptions(ms, object, &err);
>>> +
>>> +end:
>>> qapi_free_NumaOptions(object);
>>> if (err) {
>>> error_report_err(err);
>>
>> We can fix this one too while at it.
>
> Hmm - this is the same script mentioned here:
> https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06293.html
>
> Except that patch didn't pick up this file. Why is Coccinelle not
> seeing this?
>
The script only catch error_propagate(), not error_report_err(). And
error_report_err() doesn't check if err is NULL.
Thanks,
Laurent
- [Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP, Igor Mammedov, 2018/03/12
- [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions(), Igor Mammedov, 2018/03/12
- Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions(), Igor Mammedov, 2018/03/27
- Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions(), Eduardo Habkost, 2018/03/28
- Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions(), Igor Mammedov, 2018/03/29
- Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions(), Eduardo Habkost, 2018/03/29
[Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 1/9] numa: postpone options post-processing till machine_run_board_init(), Igor Mammedov, 2018/03/12