Re: [Qemu-devel] [PULL 31/36] monitor: enable IO thread for (qmp & !mux) typed

[Eric Blake]

On 03/21/2018 07:37 AM, Max Reitz wrote:
> On 2018-03-12 19:36, Eric Blake wrote:
> > From: Peter Xu <address@hidden>
> >
> > Start to use dedicate IO thread for QMP monitors that are not using
> > MUXed chardev.
> >
> > Reviewed-by: Fam Zheng <address@hidden>
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> > Signed-off-by: Peter Xu <address@hidden>
> > Message-Id: <address@hidden>
> > Signed-off-by: Eric Blake <address@hidden>
> > ---
> >   monitor.c | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
>
> It seems the iotests aren't quite ready for this change (breakage in
> 040, 041, 051, 060, 085, 087, 093, 095, 109, 124, 127, 132, 136, 144,
> 148, 152, 182, 183, 185, 186; and 030 hangs).

Serves me right for not testing iotests on my qapi tree as rigoursly as 
I do on my NBD tree.  Fixing this during freeze is acceptable, although 
I'd like it if Peter Xu can take a look instead of just me.

(And still a bummer that iotests aren't being run by 'make check' or CLI 
to have caught it earlier?)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org