Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup

[Paolo Bonzini]

On 21/03/2018 08:05, Thomas Huth wrote:
> On 20.03.2018 23:25, Michael Clark wrote:
>> The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135:
>>
>>   Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +0000)
>>
>> are available in the git repository at:
>>
>>   https://github.com/riscv/riscv-qemu.git tags/riscv-qemu-2.12-fixes
>>
>> for you to fetch changes up to e1a247183ac0816284dfda61423f7030b6686679:
>>
>>   RISC-V: Remove erroneous comment from translate.c (2018-03-20 14:34:13 
>> -0700)
>>
>> ----------------------------------------------------------------
>> This is a series of spec conformance bug fixes and code cleanups
>> that we would like to get in before the QEMU 2.12 release.
> 
>  Hi Michael,
> 
> for future PULL request, could you please send out all patches again
> that should be pulled, and not send the cover letter alone? I.e. do a
> "git format-patch --subject-prefix PULL ..." and then replace the
> contents of the cover letter with the output of "git request-pull".
> 
> ... this is how all other maintainers are sending PULL requests (at
> least as far as I know) and this way everybody gets a very final chance
> to have a look at the patches in their final state (it does not happen
> very often that someone replies to such patches, but in some rare cases
> we already found problems this way).

In fact, I already explained on the mailing list that this patch:

      RISC-V: Hold rcu_read_lock when accessing memory

is fixing the wrong place, so please remove it from the pull request too.

Thanks,

Paolo