qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] nvram: at24c: use standard error reporti


From: Wolfram Sang
Subject: Re: [Qemu-devel] [PATCH v2 3/3] nvram: at24c: use standard error reporting
Date: Mon, 19 Mar 2018 23:07:15 +0100
User-agent: NeoMutt/20170113 (1.7.2)

> > -                ERR(TYPE_AT24C_EE
> > -                        " : failed to write backing file\n");
> > +                error_report("failed to write backing file\n");
> 
> Drop the \n here and elsewhere in your patch; error_report() already does
> that for you.

Darn, I haven't installed my automatic-checkpatch-script for qemu yet :(
Sorry, will wait for more review comments and fix!

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]