Re: [Qemu-devel] [PATCH v5.1 for 2.13 0/4] tpm: Extend TPM with state migration support

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v5.1 for 2.13 0/4] tpm: Extend TPM with state 
migration support

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
1195d3f6ef tpm: Add test cases that uses the external swtpm with CRB interface
c462cd1932 docs: tpm: add VM save/restore example and troubleshooting guide
ad36584301 tpm: extend TPM TIS with state migration support
b6f35a440a tpm: extend TPM emulator with state migration support

=== OUTPUT BEGIN ===
Checking PATCH 1/4: tpm: extend TPM emulator with state migration support...
Checking PATCH 2/4: tpm: extend TPM TIS with state migration support...
Checking PATCH 3/4: docs: tpm: add VM save/restore example and troubleshooting 
guide...
Checking PATCH 4/4: tpm: Add test cases that uses the external swtpm with CRB 
interface...
ERROR: braces {} are necessary for all arms of this statement
#331: FILE: tests/tpm-util.c:36:
+    } while (g_get_monotonic_time() < end_time);
[...]

ERROR: line over 90 characters
#387: FILE: tests/tpm-util.c:92:
+gboolean tpm_util_swtpm_start(const char *path, GPid *pid, SocketAddress 
**addr, GError **error)

ERROR: braces {} are necessary for all arms of this statement
#409: FILE: tests/tpm-util.c:114:
+    for (i = 0; swtpm_argv[i]; i++)
[...]

ERROR: braces {} are necessary for all arms of this statement
#419: FILE: tests/tpm-util.c:124:
+    if (!pid)
[...]

total: 4 errors, 0 warnings, 430 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden