[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE executable |
|
Date: |
Fri, 16 Mar 2018 19:44:55 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/16/2018 07:01 PM, Peter Maydell wrote:
> PS: do you know what the intention of the
> if (reserved_va) {
> mmap_next_start = reserved_va;
> }
> code in linux-user/main.c is? It seems a bit odd to say "ok,
> we have reserved a big region. we will start trying to mmap
> outside it.", especially when that region covers the full
> 4G that the guest can access...
My guess is that it probably should have been
mmap_next_start = MIN(TASK_UNMAPPED_BASE, reserved_va);
I can't think of any other reason it should be modified at all.
r~