Re: [Qemu-devel] [PATCH] gtk: drop pointless code from gd_window_close

[Mark Cave-Ayland]

On 15/03/18 11:35, Philippe Mathieu-Daudé wrote:

> On 03/14/2018 09:04 AM, Gerd Hoffmann wrote:
> > Unregistering the display change listener looks like a pointless
> > excercise given we'll exit in a moment.  When exiting qemu via
>
> exercise
>
> > menu/file/quit this will not happen either.  Just drop the code.
> >
> > Also return TRUE unconditionally.  This will tell gtk to ignore the
> > close request, so gtk will not start destroying widgets and causing
> > warnings due to UI code trying to talk to widgets which are gone.
> > Just depend on qmp_quit() doing it's job instead.
> >
> > Reported-by: Mark Cave-Ayland <address@hidden>
> > Signed-off-by: Gerd Hoffmann <address@hidden>
>
> Looks fine to me.
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> Mark, is your issue resolved? (you might add your Tested-by).

Yes, I can confirm that this patch fixes my test case.

Tested-by: Mark Cave-Ayland <address@hidden>


ATB,

Mark.