[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12 |
Date: |
Thu, 15 Mar 2018 16:22:06 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, Mar 15, 2018 at 07:31:09PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Eduardo,
>
> On 03/13/2018 07:37 PM, Eduardo Habkost wrote:
> > On Tue, Mar 13, 2018 at 06:29:10PM +0000, Peter Maydell wrote:
> >> On 12 March 2018 at 22:34, Eduardo Habkost <address@hidden> wrote:
> >>> The following changes since commit
> >>> 6ceb1b51f05f9e1892d082960ed602dca7b6696e:
> >>>
> >>> Merge remote-tracking branch
> >>> 'remotes/kraxel/tags/audio-20180312-pull-request' into staging
> >>> (2018-03-12 16:14:37 +0000)
> >>>
> >>> are available in the Git repository at:
> >>>
> >>> git://github.com/ehabkost/qemu.git tags/machine-next-pull-request
> >>>
> >>> for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6:
> >>>
> >>> cpu: drop unnecessary NULL check and cpu_common_class_by_name()
> >>> (2018-03-12 19:33:32 -0300)
> >>>
> >>> ----------------------------------------------------------------
> >>> Machine queue, 2018-03-12
> >>>
> >>
> >> Hi. It looks like this breaks bsd-user compilation:
> >>
> >> /root/qemu/bsd-user/main.c: In function 'main':
> >> /root/qemu/bsd-user/main.c:905:5: warning: implicit declaration of
> >> function 'create' [-Wimplicit-function-declaration]
> >> cpu = create(cpu_type);
> >> ^
> >> /root/qemu/bsd-user/main.c:905:5: warning: nested extern declaration
> >> of 'create' [-Wnested-externs]
> >> /root/qemu/bsd-user/main.c:905:9: warning: assignment makes pointer
> >> from integer without a cast [enabled by default]
> >> cpu = create(cpu_type);
> >> ^
> >>
> >> and then later it fails to link with
> >> /root/qemu/bsd-user/main.c:905: undefined reference to `create'
> >
> > Oops, sorry. I don't have a BSD host handy right now, are you able to
> > confirm
> > if the new tag I pushed fixes it?
>
> You might try:
>
> $ make vm-test
> vm-test: Test QEMU in preconfigured virtual machines
>
> vm-build-ubuntu.i386 - Build QEMU in ubuntu i386 VM
> vm-build-freebsd - Build QEMU in FreeBSD VM
> vm-build-netbsd - Build QEMU in NetBSD VM
> vm-build-openbsd - Build QEMU in OpenBSD VM
This is awesome, thanks for the pointer!
--
Eduardo
- [Qemu-devel] [PULL 2/7] nios2: 10m50_devboard: replace cpu_model with cpu_type, (continued)
- [Qemu-devel] [PULL 2/7] nios2: 10m50_devboard: replace cpu_model with cpu_type, Eduardo Habkost, 2018/03/12
- [Qemu-devel] [PULL 3/7] tests: add machine 'none' with -cpu test, Eduardo Habkost, 2018/03/12
- [Qemu-devel] [PULL 4/7] cpu: add CPU_RESOLVING_TYPE macro, Eduardo Habkost, 2018/03/12
- [Qemu-devel] [PULL 5/7] Use cpu_create(type) instead of cpu_init(cpu_model), Eduardo Habkost, 2018/03/12
- [Qemu-devel] [PULL 6/7] cpu: get rid of unused cpu_init() defines, Eduardo Habkost, 2018/03/12
- [Qemu-devel] [PULL 7/7] cpu: drop unnecessary NULL check and cpu_common_class_by_name(), Eduardo Habkost, 2018/03/12
- Re: [Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12, Peter Maydell, 2018/03/13
- Re: [Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12, Igor Mammedov, 2018/03/14