[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels |
Date: |
Thu, 15 Mar 2018 13:57:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> On Wed, Mar 07, 2018 at 12:00:05PM +0100, Juan Quintela wrote:
>> In both sides. We still don't transmit anything through them.
>
> s/In/On/?
>
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> migration/ram.c | 52 ++++++++++++++++++++++++++++++++++++++++++----------
>> 1 file changed, 42 insertions(+), 10 deletions(-)
>>
>> diff --git a/migration/ram.c b/migration/ram.c
>> index b57d9fd667..7ef0c2b7e2 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -399,6 +399,7 @@ struct MultiFDSendParams {
>> uint8_t id;
>> char *name;
>> QemuThread thread;
>> + QIOChannel *c;
>> QemuSemaphore sem;
>> QemuMutex mutex;
>> bool running;
>> @@ -455,6 +456,8 @@ int multifd_save_cleanup(Error **errp)
>> qemu_thread_join(&p->thread);
>> p->running = false;
>> }
>> + socket_send_channel_destroy(p->c);
>> + p->c = NULL;
>> qemu_mutex_destroy(&p->mutex);
>> qemu_sem_destroy(&p->sem);
>> g_free(p->name);
>> @@ -514,6 +517,27 @@ static void *multifd_send_thread(void *opaque)
>> return NULL;
>> }
>>
>> +static void multifd_new_send_channel_async(QIOTask *task, gpointer opaque)
>> +{
>> + MultiFDSendParams *p = opaque;
>> + QIOChannel *sioc = QIO_CHANNEL(qio_task_get_source(task));
>> + Error *local_err = NULL;
>> +
>> + if (qio_task_propagate_error(task, &local_err)) {
>> + if (multifd_save_cleanup(&local_err) != 0) {
>
> Do we need to call multifd_save_cleanup() explicitly here?
Is the easiest way of stoping all multifd threads, no?
> Asked since I saw that it would also be called in migrate_fd_cleanup(),
> and it seems that we should call migrate_fd_cleanup() soon too when
> this happens?
We need to stop migraiton. thtat migrate_set_error() is only used for
reporting in info migrate, it is not acted upon.
Yes, perhaps it should, but as it is, it is not. So, I think it is
right O:-)
Later, Juan.
> Otherwise it looks fine to me. Thanks,
>
>> + migrate_set_error(migrate_get_current(), local_err);
>> + }
>> + } else {
>> + p->c = QIO_CHANNEL(sioc);
>> + qio_channel_set_delay(p->c, false);
>> + p->running = true;
>> + qemu_thread_create(&p->thread, p->name, multifd_send_thread, p,
>> + QEMU_THREAD_JOINABLE);
>> +
>> + atomic_inc(&multifd_send_state->count);
>> + }
>> +}
>
> [...]
- Re: [Qemu-devel] [PATCH v10 10/24] migration: In case of error just end the migration, (continued)
- [Qemu-devel] [PATCH v10 02/24] tests: Add migration xbzrle test, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 13/24] migration: Introduce multifd_recv_new_channel(), Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 18/24] migration: Add multifd traces for start/end thread, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 16/24] migration: Synchronize recv threads, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 15/24] migration: Synchronize send threads, Juan Quintela, 2018/03/07
- [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels, Juan Quintela, 2018/03/07
[Qemu-devel] [PATCH v10 23/24] migration: Create pages structure for reception, Juan Quintela, 2018/03/07
[Qemu-devel] [PATCH v10 21/24] migration: Transmit initial package through the multifd channels, Juan Quintela, 2018/03/07
[Qemu-devel] [PATCH v10 20/24] migration: Delay start of migration main routines, Juan Quintela, 2018/03/07
[Qemu-devel] [PATCH v10 22/24] migration: Create ram_multifd_page, Juan Quintela, 2018/03/07
[Qemu-devel] [PATCH v10 17/24] migration: Export functions to create send channels, Juan Quintela, 2018/03/07