[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 13/30] pc/xen: Xen Q35 support: provide IRQ
From: |
Alexey G |
Subject: |
Re: [Qemu-devel] [RFC PATCH 13/30] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices |
Date: |
Wed, 14 Mar 2018 21:28:00 +1000 |
On Wed, 14 Mar 2018 11:48:46 +0100
Paolo Bonzini <address@hidden> wrote:
>On 12/03/2018 19:33, Alexey Gerasimenko wrote:
>> xen_pci_slot_get_pirq --> xen_cmn_pci_slot_get_pirq
>> xen_piix3_set_irq --> xen_cmn_set_irq
>
>Don't abbrvt names, xen_hvm_ is a better prefix.
Agree, will rename xen_cmn_* to xen_hvm_*
>> + fprintf(stderr, "WARNING: guest domain
>> attempted to use PIRQ%c "
>> + "routing which is not supported for
>> Xen/Q35 currently\n",
>> + (char)(address - ICH9_LPC_PIRQE_ROUT +
>> 'E'));
>
>Use error_report instead.
OK, will change to error_report().
There are multiple fprintf(stderr,...)'s still left in the file though,
an additional cleanup patch to replace all such instances to
error_report() calls might be needed later.
[Qemu-devel] [RFC PATCH 18/30] xen/pt: XenHostPCIDevice: provide functions for PCI Capabilities and PCIe Extended Capabilities enumeration, Alexey Gerasimenko, 2018/03/12
[Qemu-devel] [RFC PATCH 19/30] xen/pt: avoid reading PCIe device type and cap version multiple times, Alexey Gerasimenko, 2018/03/12