Re: [Qemu-devel] [PULL 0/9] Socket next patches

[Daniel P . Berrangé]

On Tue, Mar 13, 2018 at 04:27:08PM +0000, Daniel P. Berrangé wrote:
> On Tue, Mar 13, 2018 at 04:20:19PM +0000, Peter Maydell wrote:
> > On 12 March 2018 at 20:12, Daniel P. Berrangé <address@hidden> wrote:
> > > The following changes since commit 
> > > 819fd4699c7b36d574292bcbd8bc25e9d716c84b:
> > >
> > >   Merge remote-tracking branch 
> > > 'remotes/dgilbert/tags/pull-migration-20180309a' into staging (2018-03-12 
> > > 13:21:53 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://github.com/berrange/qemu tags/socket-next-pull-request
> > >
> > > for you to fetch changes up to f4d2a296de2ccf5ff80ddd343c09f0075d10583a:
> > >
> > >   char: allow passing pre-opened socket file descriptor at startup 
> > > (2018-03-12 17:50:52 +0000)
> > >
> > > ----------------------------------------------------------------
> > >
> > > ----------------------------------------------------------------
> > >
> > > Daniel P. Berrangé (9):
> > >   char: don't silently skip tn3270 protocol init when TLS is enabled
> > >   cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int
> > >     types
> > >   sockets: pull code for testing IP availability out of specific test
> > >   sockets: strengthen test suite IP protocol availability checks
> > >   sockets: move fd_is_socket() into common sockets code
> > >   sockets: check that the named file descriptor is a socket
> > >   sockets: allow SocketAddress 'fd' to reference numeric file
> > >     descriptors
> > >   char: refactor parsing of socket address information
> > >   char: allow passing pre-opened socket file descriptor at startup
> > >
> > 
> > Test failure, 32-bit arm:
> > 
> > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> > gtester -k --verbose -m=quick tests/test-c
> > utils
> > TEST: tests/test-cutils... (pid=21029)
> >   /cutils/parse_uint/null:                                             OK
> > [etc]
> >   /cutils/parse_uint_full/trailing:                                    **
> > ERROR:/home/peter.maydell/qemu/tests/test-cutils.c:715:test_qemu_strtoui_underflow:
> > assertion failed (err =
> > = -ERANGE): (0 == -34)
> 
> This will be a genuine bug. Not sure if its in the test case or code
> yet....
> 
> > OK
> >   /cutils/parse_uint_full/correct:                                     OK
> > 
> > Test failure, x86-64 Linux:
> > 
> > TEST: tests/boot-serial-test... (pid=11205)
> >   /sparc64/boot-serial/sun4u:                                          **
> > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/boot-serial-test.c:137:check_guest_output:
> > assertion failed: (output_ok)
> > FAIL
> > GTester: last random seed: R02S99166ae475faeb3280608eeed6d61c4f
> > (pid=15216)
> 
> This feels unrelated to the series, so possibly a non-deterministic
> failure

Looking at the test source code, it has a 60 second wait for the
emulator to print expected data on the serial port. My guess
would be that when running with a highly parallel make check
we're sometimes exceeding that 60 seconds. I don't see a
reason why my series would have affected this in a way that
only failed with sparc64 qtest, and none others.

> 
> > 
> > Test failure, 64-bit arm:
> > 
> > ERROR:/home/pm215/qemu/tests/test-aio-multithread.c:365:test_multi_fair_mutex:
> > assertion failed (counter ==
> >  atomic_counter): (59827 == 59828)
> 
> I'm sure I've seen this non-deterministic failure before, unrelated to
> this series.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|