[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] linux-user: init_guest_space: Add a comme
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] linux-user: init_guest_space: Add a comment about search strategy |
Date: |
Tue, 13 Mar 2018 15:04:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Le 28/12/2017 à 19:08, Luke Shumaker a écrit :
> From: Luke Shumaker <address@hidden>
>
> Signed-off-by: Luke Shumaker <address@hidden>
> ---
> linux-user/elfload.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 1b7583d659..7736ea2c3a 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -1936,6 +1936,10 @@ unsigned long init_guest_space(unsigned long
> host_start,
> * happen often. Probably means we got unlucky and host
> * address space randomization put a shared library somewhere
> * inconvenient.
> + *
> + * This is probably a good strategy if host_start, but is
> + * probably a bad strategy if not, which means we got here
> + * because of trouble with ARM commpage setup.
> */
> munmap((void *)real_start, real_size);
> current_start += qemu_host_page_size;
>
Applied to my 'linux-user-for-2.12' branch.
Thanks,
Laurent