[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 01/21] blockjobs: fix set-speed kick
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v5 01/21] blockjobs: fix set-speed kick |
Date: |
Mon, 12 Mar 2018 14:13:58 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sat, Mar 10, 2018 at 03:27:26AM -0500, John Snow wrote:
> If speed is '0' it's not actually "less than" the previous speed.
> Kick the job in this case too.
>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockjob.c b/blockjob.c
> index 801d29d849..afd92db01f 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -499,7 +499,7 @@ void block_job_set_speed(BlockJob *job, int64_t speed,
> Error **errp)
> }
>
> job->speed = speed;
> - if (speed <= old_speed) {
> + if (speed && speed <= old_speed) {
> return;
> }
>
> --
> 2.14.3
>
Reviewed-by: Jeff Cody <address@hidden>
- [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 14/21] blockjobs: add block_job_txn_apply function, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 03/21] Blockjobs: documentation touchup, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 06/21] iotests: add pause_wait, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 12/21] blockjobs: ensure abort is called for cancelled jobs, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 18/21] blockjobs: add block-job-finalize, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 07/21] blockjobs: add block_job_verb permission table, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 08/21] blockjobs: add ABORTING state, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 01/21] blockjobs: fix set-speed kick, John Snow, 2018/03/10
- Re: [Qemu-devel] [PATCH v5 01/21] blockjobs: fix set-speed kick,
Jeff Cody <=
- [Qemu-devel] [PATCH v5 13/21] blockjobs: add commit, abort, clean helpers, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 09/21] blockjobs: add CONCLUDED state, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 02/21] blockjobs: model single jobs as transactions, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 15/21] blockjobs: add prepare callback, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 16/21] blockjobs: add waiting status, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 05/21] blockjobs: add state transition table, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 20/21] iotests: test manual job dismissal, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 21/21] tests/test-blockjob: test cancellations, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 04/21] blockjobs: add status enum, John Snow, 2018/03/10
- [Qemu-devel] [PATCH v5 10/21] blockjobs: add NULL state, John Snow, 2018/03/10