Re: [Qemu-devel] [PATCH v2 0/6] luks: Implement .bdrv_co_create

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/6] luks: Implement .bdrv_co_create

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
21707c7252 qemu-iotests: Test luks QMP image creation
c3cce1168f luks: Catch integer overflow for huge sizes
bee065e0ba luks: Turn invalid assertion into check
b9d31479f8 luks: Support .bdrv_co_create
2dc9f95b59 luks: Create block_crypto_co_create_generic()
26821e37e9 luks: Separate image file creation from formatting

=== OUTPUT BEGIN ===
Checking PATCH 1/6: luks: Separate image file creation from formatting...
Checking PATCH 2/6: luks: Create block_crypto_co_create_generic()...
Checking PATCH 3/6: luks: Support .bdrv_co_create...
Checking PATCH 4/6: luks: Turn invalid assertion into check...
ERROR: suspect code indent for conditional statements (4, 7)
#31: FILE: block/crypto.c:522:
+    if (offset > len) {
+       return -EIO;

total: 1 errors, 0 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: luks: Catch integer overflow for huge sizes...
Checking PATCH 6/6: qemu-iotests: Test luks QMP image creation...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden