Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

[Gerd Hoffmann]

  Hi,

> I don't know the hw/display code very well, but I think it's not that
> easy... Putting Gerd on CC:, maybe he can describe the details of that
> BiteSizeTask a little bit better.

[ Side note: Is there a wiki page for this? ]

Might be it actually is that easy.

Historically qemu created DisplaySurfaces according to the needs of user
interface code, which could be all kinds of formats, and the rendering
code of the display emulation had to deal with it.

These days you always get 32bpp DisplaySurfaces unless you explicitly
do something else.  Code which uses qemu_console_resize() +
qemu_console_surface() or qemu_create_displaysurface() only need to
handle 32bpp rendering outout (PIXMAN_x8r8g8b8 to be exact, i.e. xRGB in
host native byte order).

But note that this applies to rendering only.  Sometimes there is pixel
bit shuffeling code which is part of the device emulation (the cirrus
blitter for example).  This must continue to support all formats of
course.

cheers,
  Gerd