Re: [Qemu-devel] [PATCH 2/6] luks: Create block_crypto_co_create_generic()

[Eric Blake]

On 03/09/2018 11:27 AM, Kevin Wolf wrote:
> Everything that refers to the protocol layer or QemuOpts is moved out of
> block_crypto_create_generic(), so that the remaining function is
> suitable to be called by a .bdrv_co_create implementation.
>
> LUKS is the only driver that actually implements the old interface, and
> we don't intend to use it in any new drivers, so put the moved out code
> directly into a LUKS function rather than creating a generic
> intermediate one.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   block/crypto.c | 95 +++++++++++++++++++++++++++++++++++++---------------------
>   1 file changed, 61 insertions(+), 34 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org