Re: [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable

[Michael Clark]

On Sat, 10 Mar 2018 at 12:17 AM, Michael Clark <address@hidden> wrote:

> On Fri, 9 Mar 2018 at 11:45 PM, Peter Maydell <address@hidden>
> wrote:
>
>> On 9 March 2018 at 04:22, Michael Clark <address@hidden> wrote:
>> > I need to dig into this. I'll need to take the assertions out, or run
>> with
>> > tracing to see which fcvt test is triggering this unreachable piece of
>> > code. FYI. I can look into it.
>>
>> >
>> ERROR:/Users/mclark/src/sifive/riscv-qemu/fpu/softfloat.c:1374:round_to_int_and_pack:
>> > code should not be reached
>> > qemu-images/run-tests.sh: line 6: 58437 Abort trap: 6           ${QEMU}
>> > -nographic -machine spike_v1.10 -kernel $i
>>
>> This looks like maybe it's the issue Richard Jones sent a patch for ?
>> https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg01005.html
>
>
> Thanks. Seems I wasn’t on the ‘cc.
>
> We need this patch in our downstream repo... We also need to automate
> riscv-tests in the riscv.org repo .travis.yml so we can pick these things
> up automatically...
>

BTW how does one hide signed-off-by or cc email addresses with the
git-send-email workflow?

Seems like editing the patch after git format-patch is likely the only way
around for contributors whose wishes I might not have honoured, except
originally when I was using an advoc albeit buggy workflow, where the Cc’s
et all we’re later added to the patch headers and not the commits. I’ve
probably inadvertently violated someone’s wish to keep their email address
out of the list archives, which is an understandable wish.

This is not an issue with GitHub PR’s as they keep identity information
differently however slicing up the port for upstreaming has lost some of
our contributor history. I have made tags before every squash and rebase so
we can find all history in the riscv repo, as well as previously trying to
keep personal emails out of the cover letters in the first series. With the
change to the git-sendemail  workflow i’ve likely regressed here.

I also probably have to manually edit patches to add ‘Cc to the
riscv-patches mailing list, as it doesn’t seem right to put that email in
the commit messages.

I’ll guess we’ll figure it all out eventually...

Michael

>