Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

[Thomas Huth]

On 09.03.2018 10:44, Gerd Hoffmann wrote:
> On Fri, Mar 09, 2018 at 10:15:33AM +0100, Gerd Hoffmann wrote:
>> On Fri, Mar 09, 2018 at 09:46:44AM +0100, Thomas Huth wrote:
>>> On 09.03.2018 08:50, Gerd Hoffmann wrote:
>>>>   Hi,
>>>>
>>>>> Maybe I should move the code to a separate source file so it can be
>>>>> built with different compiler flags, without needing #pragma?  I don't
>>>>> feel like building all gtk code with -Wno-deprecated-declarations ...
>>>>
>>>> Hmm, that idea doesn't fly, seems per-object cflags don't work for
>>>> object files which get linked into a module.
>>>>
>>>> Other ideas anyone?
>>>
>>> Maybe simply remove the '#pragma GCC diagnostic ignored
>>> "-Wunused-but-set-variable"' from the configure test and change
>>> util/coroutine-ucontext.c:
>>
>> I'll try.  Will probably have the effect that freebsd builds with
>> -Werror then (which is now turned off by configure due to missing
>> pragma support), which might trigger more issues ...
> 
> Well, guessed almost right.  -Werror is enabled on linux only, so
> freebsd builds do not fail.  But clang builds on linux fail, due to a
> bunch of warnings (now errors) about unaligned access to struct members.

Ugh, this is getting messy ... could you maybe turn them back into
warnings again with -Wno-error=... when compiling with clang?

 Thomas