[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/2] Drop dead linux-user/unicore32 code
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 0/2] Drop dead linux-user/unicore32 code |
Date: |
Thu, 8 Mar 2018 14:47:31 +0000 |
We disabled the unicore32-linux-user in commit 5e2b40f7271cf9d
in 2016, due to a problem with the syscall ABI it implemented
being out of date and out of sync with the mainline kernel.
In the intervening year and a half there have been no proposals
to fix these problems so that we could re-enable it. This
patchset removes the 750 lines of dead code from linux-user.
(I suggested this in
https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg06634.html
and there were no objections.)
The second patch is a cleanup we can make as a result, since
with unicore32 gone all our targets implement signal handling:
we can remove the default "not implemented" stub functions.
You could argue that these might be helpful for future new targets,
but IMHO signal handling support is too important to allow a
hypothetical new target to silently get away without implementing
it. For initial development it's easy enough to stub out the
per-architecture functions, and then we will have a clear view of
which targets (if any) don't have the signal handling implemented
yet, and the missing feature will show up in code review.
thanks
-- PMM
Peter Maydell (2):
linux-user: Drop unicore32 code
linux-user: Remove the unused "not implemented" signal handling stubs
linux-user/qemu.h | 5 +-
linux-user/syscall_defs.h | 6 +-
linux-user/unicore32/syscall_nr.h | 371 ----------------------------------
linux-user/unicore32/target_cpu.h | 27 ---
linux-user/unicore32/target_elf.h | 14 --
linux-user/unicore32/target_signal.h | 30 ---
linux-user/unicore32/target_structs.h | 58 ------
linux-user/unicore32/target_syscall.h | 62 ------
linux-user/unicore32/termbits.h | 2 -
linux-user/elfload.c | 72 -------
linux-user/main.c | 99 +--------
linux-user/signal.c | 32 +--
12 files changed, 7 insertions(+), 771 deletions(-)
delete mode 100644 linux-user/unicore32/syscall_nr.h
delete mode 100644 linux-user/unicore32/target_cpu.h
delete mode 100644 linux-user/unicore32/target_elf.h
delete mode 100644 linux-user/unicore32/target_signal.h
delete mode 100644 linux-user/unicore32/target_structs.h
delete mode 100644 linux-user/unicore32/target_syscall.h
delete mode 100644 linux-user/unicore32/termbits.h
--
2.16.2
- [Qemu-devel] [PATCH 0/2] Drop dead linux-user/unicore32 code,
Peter Maydell <=