[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 34/37] file-posix: Fix no-op bdrv_truncate() with
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v4 34/37] file-posix: Fix no-op bdrv_truncate() with falloc preallocation |
Date: |
Wed, 7 Mar 2018 19:59:43 +0100 |
If bdrv_truncate() is called, but the requested size is the same as
before, don't call posix_fallocate(), which returns -EINVAL for length
zero and would therefore make bdrv_truncate() fail.
The problem can be triggered by creating a zero-sized raw image with
'falloc' preallocation mode.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/file-posix.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index fbc21a9921..d7fb772c14 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1686,11 +1686,15 @@ static int raw_regular_truncate(int fd, int64_t offset,
PreallocMode prealloc,
* file systems that do not support fallocate(), trying to check if a
* block is allocated before allocating it, so don't do that here.
*/
- result = -posix_fallocate(fd, current_length, offset - current_length);
- if (result != 0) {
- /* posix_fallocate() doesn't set errno. */
- error_setg_errno(errp, -result,
- "Could not preallocate new data");
+ if (offset != current_length) {
+ result = -posix_fallocate(fd, current_length, offset -
current_length);
+ if (result != 0) {
+ /* posix_fallocate() doesn't set errno. */
+ error_setg_errno(errp, -result,
+ "Could not preallocate new data");
+ }
+ } else {
+ result = 0;
}
goto out;
#endif
--
2.13.6
- Re: [Qemu-devel] [PATCH v4 22/37] rbd: Pass BlockdevOptionsRbd to qemu_rbd_connect(), (continued)
- [Qemu-devel] [PATCH v4 23/37] rbd: Support .bdrv_co_create, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 27/37] nfs: Support .bdrv_co_create, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 25/37] rbd: Use qemu_rbd_connect() in qemu_rbd_do_create(), Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 29/37] sheepdog: Support .bdrv_co_create, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 33/37] ssh: Support .bdrv_co_create, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 28/37] sheepdog: QAPIfy "redundancy" create option, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 26/37] nfs: Use QAPI options in nfs_client_open(), Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 32/37] ssh: Pass BlockdevOptionsSsh to connect_to_ssh(), Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 34/37] file-posix: Fix no-op bdrv_truncate() with falloc preallocation,
Kevin Wolf <=
- [Qemu-devel] [PATCH v4 31/37] ssh: QAPIfy host-key-check option, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 30/37] ssh: Use QAPI BlockdevOptionsSsh object, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 35/37] block: Fail bdrv_truncate() with negative size, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 37/37] qemu-iotests: Test ssh image creation over QMP, Kevin Wolf, 2018/03/07
- [Qemu-devel] [PATCH v4 36/37] qemu-iotests: Test qcow2 over file image creation with QMP, Kevin Wolf, 2018/03/07
- Re: [Qemu-devel] [PATCH v4 00/37] x-blockdev-create for protocols and qcow2, no-reply, 2018/03/07
- Re: [Qemu-devel] [PATCH v4 00/37] x-blockdev-create for protocols and qcow2, Daniel P . Berrangé, 2018/03/08