Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

[Kamil Rytarowski]

On 07.03.2018 10:38, Philippe Mathieu-Daudé wrote:
> On 03/07/2018 06:13 AM, Kamil Rytarowski wrote:
>> This patch is correct. LLDB expects 1sec for reply, GDB by default 2.
>>
>> Debuggers use this option to disable Nagle algorithm in order to quickly
>> transfer messages between gdb-server and gdb-client. It's also fairy
>> portable across systems.
>>
>> On 04.01.2018 18:56, Andreas Gustafsson wrote:
>>> slirp: disable Nagle in outgoing connections
>>>
>>> When setting up an outgoing user mode networking TCP connection,
>>> disable the Nagle algorithm in the host-side connection.  Either the
>>> guest is already doing Nagle, in which case there is no point in doing
>>> it twice, or it has chosen to disable it, in which case we should
>>> respect that choice.
>>>
>>> This change speeds up GDB remote debugging over TCP over user mode
>>> networking (with GDB runing on the guest) by multiple orders of
>>> magnitude, and has been part of the local patches applied by pkgsrc
>>> since 2012 with no reported ill effects.
>>>
>>> Signed-off-by: Andreas Gustafsson <address@hidden>
>>
>> Signed-off-by: Kamil Rytarowski <address@hidden>
> 
> I suppose you meant "Reviewed-by: Kamil Rytarowski <address@hidden>"
> 

Correct!

> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>

signature.asc
Description: OpenPGP digital signature