[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview call |
Date: |
Tue, 6 Mar 2018 18:46:03 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 05/03/18 19:36, Paolo Bonzini wrote:
> The MemoryListener is registered on address_space_memory, there is
> not much to assert. This currently works because the callback
> is invoked only once when the listener is registered, but section->fv
> is the _new_ FlatView, not the old one on later calls and that
> would break.
>
> This confines address_space_to_flatview to exec.c and memory.c.
>
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Alexey Kardashevskiy <address@hidden>
> ---
> hw/intc/openpic_kvm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c
> index fa83420254..39a6f369c5 100644
> --- a/hw/intc/openpic_kvm.c
> +++ b/hw/intc/openpic_kvm.c
> @@ -124,10 +124,6 @@ static void kvm_openpic_region_add(MemoryListener
> *listener,
> uint64_t reg_base;
> int ret;
>
> - if (section->fv != address_space_to_flatview(&address_space_memory)) {
> - abort();
> - }
> -
> /* Ignore events on regions that are not us */
> if (section->mr != &opp->mem) {
> return;
>
--
Alexey
- [Qemu-devel] [PATCH 0/7] memory: address_space_to_flatview needs RCU lock, Paolo Bonzini, 2018/03/05
- [Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview call, Paolo Bonzini, 2018/03/05
- [Qemu-devel] [PATCH 2/7] memory: inline some performance-sensitive accessors, Paolo Bonzini, 2018/03/05
- [Qemu-devel] [PATCH 3/7] address_space_write: address_space_to_flatview needs RCU lock, Paolo Bonzini, 2018/03/05
- [Qemu-devel] [PATCH 5/7] address_space_access_valid: address_space_to_flatview needs RCU lock, Paolo Bonzini, 2018/03/05
- [Qemu-devel] [PATCH 6/7] address_space_map: address_space_to_flatview needs RCU lock, Paolo Bonzini, 2018/03/05
- [Qemu-devel] [PATCH 4/7] address_space_read: address_space_to_flatview needs RCU lock, Paolo Bonzini, 2018/03/05