[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_io
From: |
Liu, Yi L |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu() |
Date: |
Mon, 5 Mar 2018 16:43:09 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 02, 2018 at 05:06:56PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > + pci_device_notify_iommu(pdev, PCI_NTY_DEV_ADD);
> > +
> > pci_setup_sva_ops(pdev, &vfio_pci_sva_ops);
> >
> > return;
> > @@ -3134,6 +3136,7 @@ static void vfio_exitfn(PCIDevice *pdev)
> > {
> > VFIOPCIDevice *vdev = DO_UPCAST(VFIOPCIDevice, pdev, pdev);
> >
> > + pci_device_notify_iommu(pdev, PCI_NTY_DEV_DEL);
>
> Please make the names longer: PCI_IOMMU_NOTIFY_DEVICE_ADDED and
> PCI_IOMMU_NOTIFY_DEVICE_REMOVED. (This is independent of my other
> remark, about doing this in generic PCI code for all devices that
> register SVA ops).
Thanks for the suggestion, will appply.
Regards,
Yi Liu
- Re: [Qemu-devel] [PATCH v3 09/12] intel_iommu: record assigned devices in a list, (continued)
[Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/01
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Paolo Bonzini, 2018/03/02
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/05
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Paolo Bonzini, 2018/03/06
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/06
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Paolo Bonzini, 2018/03/06
- Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/06
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Paolo Bonzini, 2018/03/02
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(),
Liu, Yi L <=
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Peter Xu, 2018/03/05
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Paolo Bonzini, 2018/03/06
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Peter Xu, 2018/03/06
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/06
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Peter Xu, 2018/03/05
Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu(), Liu, Yi L, 2018/03/05
[Qemu-devel] [PATCH v3 12/12] intel_iommu: bind device to PASID tagged AddressSpace, Liu, Yi L, 2018/03/01
Re: [Qemu-devel] [PATCH v3 12/12] intel_iommu: bind device to PASID tagged AddressSpace, Peter Xu, 2018/03/06